Refactor verify_owner for readability

ncbo · Nov 20, 2024 · a88e780 · a88e780
1 parent d1161dd
commit a88e780
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/app/controllers/users_controller.rb b/app/controllers/users_controller.rb
@@ -141,9 +141,10 @@ def unescape_id
   def verify_owner
     return if current_user_admin?
 
-    if session[:user].nil? || (!session[:user].id.eql?(params[:id]) && !session[:user].username.eql?(params[:id]))
-      redirect_to controller: 'login', action: 'index', redirect: "/accounts/#{params[:id]}"
-    end
+    user = session[:user]
+    return if user&.id == params[:id] || user&.username == params[:id]
+
+    redirect_to login_index_path(redirect: "/accounts/#{params[:id]}")
   end
 
   def get_ontology_list(ont_hash)