Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding proposals results in unnecessary frame reloading #351

Open
jvendetti opened this issue Nov 15, 2024 · 3 comments
Open

Adding proposals results in unnecessary frame reloading #351

jvendetti opened this issue Nov 15, 2024 · 3 comments

Comments

@jvendetti
Copy link
Member

In the master branch (production environment):

When a user selects any item from the "Add a proposal" dropdown menu and successfully submits a change proposal, the proposal form is hidden and a success message is inserted at the top of the Details pane.

To access this dropdown menu, navigate to the Classes -> Details tab for any ontology where change requests are enabled. For a list of ontologies where change requests are enabled, refer to the change_request YAML file.

In the sync-agroportal branch:

When a user selects any item from the "Add a proposal" dropdown menu and successfully submits a change proposal, the entire content of the right-hand side of the Classes tab is blanked-out and reloaded.

After the reload completes, the proposal form is hidden (as expected) and the success message is displayed (as expected). I don't consider this a show-stopper, but want to document that the code no longer works as I originally designed. The reason I adopted Turbo Streams in this part of the code is to limit page updates to only the areas needed and avoid reloading content that's unaffected by change proposals.

@jvendetti
Copy link
Member Author

Screen recording that shows current behavior in the master branch:

Screen.Recording.2024-11-15.at.12.08.43.PM.mov

@jvendetti
Copy link
Member Author

Screen recording that shows behavior in the sync-agroportal branch:

Screen.Recording.2024-11-15.at.12.09.43.PM.mov

@mdorf
Copy link
Member

mdorf commented Nov 18, 2024

This appears to be fixed in this commit ontoportal@c4c5258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants