Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suboptimal loading indicator for loading classes #359

Open
jvendetti opened this issue Nov 18, 2024 · 3 comments
Open

Suboptimal loading indicator for loading classes #359

jvendetti opened this issue Nov 18, 2024 · 3 comments

Comments

@jvendetti
Copy link
Member

In the master branch we have a "Loading Class..." indicator that displays in the center of the screen while BioPortal fetches class data. To reproduce:

  1. Navigate to an ontology, e.g., SNOMEDCT
  2. Select the Classes tab and type a class name in the "Jump to:" box
  3. Select any class from the list of results

Notice that BioPortal immediately displays a "Loading Class..." indicator in the center of the screen that makes it clear and obvious to a user that BioPortal is retrieving / preparing to display the class data. I acknowledge that this indicator is kind of dated looking, but we have a lot of classes in the system that take > 5 seconds to load, so I consider it important.

The first time I selected a result from "Jump to:" in the sync-agroportal branch it looked like nothing happened and I thought the code was broken. Then about 7 seconds later the class I selected rendered, and I thought our loading indicator had simply been removed. It wasn't until I tested the functionality in AgroPortal that I realized there's a new loading indicator in the form of a thin blue line that appears at the very top of the page. I noticed the line on their site because they have a medium green header. In BioPortal I had no idea it was there - I think because it gets lost next to our dark blue header.

Screen.Recording.2024-11-15.at.4.08.01.PM.mov
@jvendetti
Copy link
Member Author

As a first pass I might suggest changing the color of the loading indicator to... white maybe? However, I'm not certain if that would be sufficient. If we get complaints from end users I think we should revert to something more obvious like what we have now.

@mdorf
Copy link
Member

mdorf commented Nov 18, 2024

@jvendetti
Copy link
Member Author

That's definitely more obvious than the blue line. I think the appearance could do with more refining, but it you want to release it as-is I don't object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants