Notifications sends separate emails for archived status with vague content

[jvendetti]

I'm listed as an administrator for the ARO ontology. I got an email at 6:03pm that a new version was processed with a title of "Antibiotic Resistance Ontology Parsing Success". The content is:

Antibiotic Resistance Ontology (ARO) was processed for use in BioPortal. Here are the results:

Parsed successfully
Indexed terms for search
Indexed properties for search
Class metrics calculated
Created submission version diff successfully
...

I got a second email (also at 6:03pm) with the identical title of "Antibiotic Resistance Ontology Parsing Success". The content is:

Antibiotic Resistance Ontology (ARO) was processed for use in BioPortal. Here are the results:

Archived
...

Since I know BioPortal's internals, I read this and understood that since a new submission was uploaded, we archived the previous submission. However, there are lots of BioPortal users who administer ontologies and don't know anything about our internals. I find the content potentially confusing to users who might wonder what archived is even referring to with regard to their ontology. I also don't think we should generate multiple messages when new submissions are processed.

[alexskr]

I agree, second email notification about submission archival is not needed
see also #185 (comment)

[alexskr]

relates to ncbo/bioportal-project#291

[jvendetti]

Production was rolled back on May 8th to v5.29.1. This behavior is occurring again. Reopening this as a reminder to make sure the fixes are correctly re-deployed.