-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
design formative element dictionary content, goals, editing suggestions #17
Comments
So, I am proposing we remove the redundancy from the formative element table. We already are partitioning meaning by the levels of ST... but indeed this is only the tip of the ice berg. I don't know that we want to go the route of doing this for all the instances this kind of thing affects. Here is an example. Currently we have:
Which produces identical results to the simplest case:
Now,
As it stands we have a mixture of degrees of specificity of these definitions... some refer to actual existing definitions in soil taxonomy, whereas others simplify the meaning. We can go and define all of instances I gave above as their own definition, and it works, or we can go the route of not actually identifying the specific relevant definitions and criteria in these more generalized explanations. I know @dylanbeaudette has discussed different levels of detail for this output, and I think the current defnitions we are using probably span what would be a couple different levels as is. |
From Soil Taxonomy (2003), CHAPTER 6 The Categories of Soil Taxonomy, p. 119. https://www.nrcs.usda.gov/Internet/FSE_DOCUMENTS/nrcs142p2_051232.pdf I think we need to work these definitions into the
|
I think some of the explanations need revision. For instance "typic" probably should read "central theme of great group concept" (not "subgroup"). library(SoilTaxonomy)
cat(explainST('typic endoaqualfs'))
#> typic endoaqualfs
#> | | | |
#> central theme of subgroup concept
#> | | |
#> ground water table
#> | |
#> characteristics associated with wetness
#> |
#> soils with an argillic, kandic, or natric horizon Also, we should consider using/replacing some the connotations included in latest versions of the Keys e.g. "Hapl" -> "minimum horizon development" rather than "central theme of subgroup concept" Also consider adding historical formative elements no longer used in modern versions of Taxonomy |
Add 'wassi' formative element. |
"wassi" is not a formative element. "wass" is the formative element, followed by "i" (h_i_stosols) or "e" (_e_ntisols).
library(SoilTaxonomy)
data("ST_unique_list")
lapply(ST_unique_list, \(x) x[grep("wass", x)])
#> $order
#> character(0)
#>
#> $suborder
#> [1] "wassists" "wassents"
#>
#> $greatgroup
#> [1] "frasiwassists" "sulfiwassists" "haplowassists" "frasiwassents"
#> [5] "psammowassents" "sulfiwassents" "hydrowassents" "fluviwassents"
#> [9] "haplowassents"
#>
#> $subgroup
#> [1] "fibric frasiwassists" "sapric frasiwassists"
#> [3] "typic frasiwassists" "fibric sulfiwassists"
#> [5] "sapric sulfiwassists" "typic sulfiwassists"
#> [7] "sulfic haplowassists" "fibric haplowassists"
#> [9] "sapric haplowassists" "typic haplowassists"
#> [11] "lithic frasiwassents" "psammentic frasiwassents"
#> [13] "thapto-histic frasiwassents" "fluventic frasiwassents"
#> [15] "aeric frasiwassents" "typic frasiwassents"
#> [17] "sulfic psammowassents" "lithic psammowassents"
#> [19] "fluventic psammowassents" "aeric psammowassents"
#> [21] "typic psammowassents" "lithic sulfiwassents"
#> [23] "haplic sulfiwassents" "thapto-histic sulfiwassents"
#> [25] "fluventic sulfiwassents" "aeric sulfiwassents"
#> [27] "typic sulfiwassents" "sulfic hydrowassents"
#> [29] "grossic hydrowassents" "lithic hydrowassents"
#> [31] "thapto-histic hydrowassents" "typic hydrowassents"
#> [33] "sulfic fluviwassents" "lithic fluviwassents"
#> [35] "thapto-histic fluviwassents" "aeric fluviwassents"
#> [37] "typic fluviwassents" "sulfic haplowassents"
#> [39] "lithic haplowassents" "aeric haplowassents"
#> [41] "typic haplowassents" cat(explainST("sulfic haplowassents"))
#> sulfic haplowassents
#> | | | |
#> presence of sulfides
#> | | |
#> minimum horizon development
#> | |
#> daily under shallow water
#> |
#> other soils cat(explainST("sapric frasiwassists"))
#> sapric frasiwassists
#> | | | |
#> >25cm of sapric organic material
#> | | |
#> not salty
#> | |
#> daily under shallow water
#> |
#> soils with more than 30% organic matter content to a depth of 40cm or more |
Fat finger typo, thanks. I think that I had been using an older version of I'll try to return to the meat of this issue this November. |
Sub-Issues:
The text was updated successfully, but these errors were encountered: