Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple RV component texture group records results in duplicate horizons/logic fail #32

Closed
brownag opened this issue Sep 26, 2017 · 1 comment
Labels
bug NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions

Comments

@brownag
Copy link
Member

brownag commented Sep 26, 2017

Noticed today that I had inadvertently checked two texture groups as RV for one of my component horizons.

The component wouldn't load via fetchNASIS_component_data() due to failing test_hz_logic(). The reason why was not immediately obvious from my NASIS horizon table.

Multiple RVs results in the duplication/overlap AFTER loading from DB when compressing the chorizon texture group table down to the texture field within the component SPC.

Was handy that this happened, as otherwise it would have persisted in there until I ran the RV validation, but it might be helpful to catch "multiple RV" issues with a more informative error message.

Also, should there be safeguards to prevent duplication of a record because of a many-to-one compression gone bad? or one that is "intractable" without a human decision? I can't currently think of a case where duplicating would be desired behavior.

@brownag brownag added the bug label Sep 26, 2017
@brownag brownag added the NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions label Jan 16, 2021
brownag added a commit that referenced this issue Apr 28, 2023
@brownag
Copy link
Member Author

brownag commented Apr 28, 2023

This issue also applies to multiple RV structure group. Not as much of an issue with default rmHzErrors=FALSE as the duplication does not lead to loss of data, just logic errors which the SPC is generally more robust to now.

I fixed an issue that prevented from displaying the QC note about horizon errors detected, so users should be alerted to some aspect of the data quality issue. This works to detect duplication regardless of the source of the problem.

In the future we can develop a method that can take a list of components with horizon problems and give a better explanation about what is different between otherwise duplicated layers (#89)

@brownag brownag closed this as completed Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NASIS-local This tag is used for pull requests, issues, discussions etc. for soilDB local NASIS functions
Projects
None yet
Development

No branches or pull requests

1 participant