fix: contract unit tests #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
previously approved these changes
Oct 22, 2024
|
Seems not triggering the contract unit test, see unit/check & test log |
|
for some reason, we don't have the equivalent commands for running the chain signatures unit tests in CI which is strange. I remember we had one once upon a time but don't know where it went |
ppca
approved these changes
Oct 25, 2024
volovyks
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix all the contract's unit testing. This also commits the
Cargo.lockfile for chain-signatures/contract so hopefully that also fixes integration tests in GH action if stuff is being cached