Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade needed for pytorch 0.4+ #6

Open
fac2003 opened this issue Aug 2, 2018 · 2 comments
Open

Upgrade needed for pytorch 0.4+ #6

fac2003 opened this issue Aug 2, 2018 · 2 comments

Comments

@fac2003
Copy link

fac2003 commented Aug 2, 2018

The current master won't work with pytorch 0.4: isinstance cannot test for TensorBase anymore and there are other issues discussed in the migration guide.
I have migrated torchfold in this fork: https://github.com/CampagneLaboratory/torchfold/tree/pytorch_0.4.1
Note that the branch also partly addresses an issue with incorrect logic in the training loop of the example, so let me know if you want a PR.

@ilblackdragon
Copy link
Member

@fac2003 Sorry for late reply. Feel free to send the PR to upgrade to v1.0 if that's still interesting.
Thanks!

@fac2003
Copy link
Author

fac2003 commented Dec 6, 2018

I will need to use torchfold in the very near future with 1.0, and can send a PR when I have tested the code with pytorch 1.0. Note that the upgrade to 0.4 should cover most of the API changes. 0.4 and 1.0rc1 are quite similar in term of API.

@gameking157
Copy link

update to 1.0 please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants