Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doen't convert yarn command to pnpm, pnpm to npm/yarn #40

Open
dimaMachina opened this issue Jun 5, 2023 · 3 comments · May be fixed by #59
Open

doen't convert yarn command to pnpm, pnpm to npm/yarn #40

dimaMachina opened this issue Jun 5, 2023 · 3 comments · May be fixed by #59

Comments

@dimaMachina
Copy link

dimaMachina commented Jun 5, 2023

> require('npm-to-yarn')('yarn add foo', 'npm');
'npm install foo'
> require('npm-to-yarn')('yarn add foo', 'pnpm');
'yarn add foo'

pnpm

> require('npm-to-yarn')('pnpm add foo', 'npm');
'pnpm add foo'
> require('npm-to-yarn')('pnpm add foo', 'yarn');
"pnpm add foo\n# couldn't auto-convert command"
@dimaMachina dimaMachina changed the title doen't convert yarn command to pnpm doen't convert yarn command to pnpm, pnpm to npm/yarn Jun 5, 2023
@nebrelbug
Copy link
Owner

This isn't supported by the library right now, but PRs are welcome!

@dimaMachina
Copy link
Author

I think the source code should be simplified, and yarnToNpm.ts should be removed (because we already have npmToYarn)

all commands should be translated no matter you pass yarn add or pnpm add

@Jay-Karia
Copy link
Contributor

Here's a list of commands conversion which does not work:

yarn - pnpm
yarn - bun

pnpm - npm
pnpm - yarn
pnpm - bun

bun - npm
bun - yarn
bun - pnpm

Will send a pull fixing this

@Jay-Karia Jay-Karia linked a pull request Aug 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants