Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Animated from React Native #716

Closed
necolas opened this issue Nov 15, 2017 · 3 comments
Closed

Use Animated from React Native #716

necolas opened this issue Nov 15, 2017 · 3 comments

Comments

@necolas
Copy link
Owner

necolas commented Nov 15, 2017

animatedjs/animated has not kept up with React Native's changes to Animated. Moving back to copy-paste from React Native should make it easier to ensure API compatibility.

See #714 #688 #684

@vaukalak
Copy link
Contributor

vaukalak commented Dec 2, 2017

What is the issue of making react-native a dependency of react-native-web and just expose there api? Or maybe we should create an issue for react-native to move js animations part to separate module?

@necolas
Copy link
Owner Author

necolas commented Dec 2, 2017

I'm not going to have everyone install the whole of react native to do this. Yeah I don't know why it hasn't been extracted from react native. That was the point of the animated repo but it hasn't worked out that way

@piranna
Copy link

piranna commented Dec 13, 2017

Or maybe we should create an issue for react-native to move js animations part to separate module?

We could open the issue, or we could do the separated module ourselves to see if they adopt it.

Anyway, since this is already merged in master, can it be published to npm? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants