Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable logger #64

Closed
vemv opened this issue Apr 26, 2019 · 3 comments
Closed

Configurable logger #64

vemv opened this issue Apr 26, 2019 · 3 comments

Comments

@vemv
Copy link
Contributor

vemv commented Apr 26, 2019

Linters' output can clog the REPL, particularly when working with 'legacy' projects.

Would be nice to have a configurable logger, which would follow a hierarchy as per usual (global -> per-member)

@thumbnail
Copy link
Member

Recently i've played around with the idea of a configurable reporter for all linters/formatters to aid with #88 and #48. The reporter could be configured to output the warnings into a file, which one could continiously read using watch --color -n 1 cat ./<file>.

POC:
image

This would be an extra step though for the dev to remember. I wondered about reading a socket and printing unless the socket is mounted. ensuring that the linting is not lost.

@vemv
Copy link
Contributor Author

vemv commented Jan 19, 2020

Looking good!

In the end it'd be a configurable choice (stdout, file, ...) so feel free to proceed

@thumbnail thumbnail mentioned this issue Jan 19, 2020
32 tasks
@vemv
Copy link
Contributor Author

vemv commented Feb 17, 2020

which would follow a hierarchy as per usual (global -> per-member)

with this I had meant that similarly to strategies, there could be a default logger object passed to the stack, and each member (e.g. a specific linter) could replace it, or assoc things to it etc.

Our final design was different, guided for the need for unifying various loggers' output (for comprehensibility).

The tradeoff was perceived performance, as hinted in #116 (comment) ; but probably we'll be able to address it somehow.

@vemv vemv closed this as completed Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants