Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented prototype for nested skills #2

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from

Conversation

maikenp
Copy link

@maikenp maikenp commented Jan 24, 2020

Resolves #2

@bast
Copy link
Member

bast commented Jan 26, 2020

Is this pull request addressing/fixing #3?

@maikenp
Copy link
Author

maikenp commented Jan 26, 2020

Hi, yes I referred to the MR in the issue, but not the other way around. A bit confusing the # is used both for issue and MR ref. How to know what is what?

@bast
Copy link
Member

bast commented Jan 26, 2020

If you want the MR/PR to close the issue it's better to refer to it in the title or text or commmits (assuming that you want this to close the issue), see: https://help.github.com/en/github/managing-your-work-on-github/closing-issues-using-keywords

@bast
Copy link
Member

bast commented Jan 26, 2020

Hi, yes I referred to the MR in the issue, but not the other way around. A bit confusing the # is used both for issue and MR ref. How to know what is what?

In GitHub they share the same number space (in contrast to GitLab). But there cannot be a conflict.

@bast
Copy link
Member

bast commented Feb 12, 2020

This is not forgotten. I am now soon picking this up and will move it forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants