Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show large files upload progress (Firmware) #369

Open
kevinleguillou opened this issue Jan 31, 2025 · 2 comments
Open

Show large files upload progress (Firmware) #369

kevinleguillou opened this issue Jan 31, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@kevinleguillou
Copy link

Is your feature request related to a problem? Please describe.
I just used Pocket Sync v5.5.0 to update my firmware and I kept trying to reboot my Pocket to install it, and nothing was happening. I noticed the firmware was 0 bytes so I checked the logs but nothing seemed wrong. After a while I realized that the SD card upload was just slow.

Describe the solution you'd like
Displaying a progress bar instead of instantly showing Firmware pocket_firmware_2_4.bin is on the SD card.

Additional context
Since the upload can take more than 1 minute, it's easy to unplug the Pocket before it's done uploading.

[2025-01-31][12:31:01][pocket_sync][DEBUG] Command: download_firmware
[2025-01-31][12:31:01][reqwest::connect][DEBUG] starting new connection: https://assets.analogue.co/
[2025-01-31][12:31:02][pocket_sync][DEBUG] Command: list_files - 
[2025-01-31][12:32:27][pocket_sync][DEBUG] firmware downloaded
@kevinleguillou kevinleguillou added the enhancement New feature or request label Jan 31, 2025
@neil-morrison44
Copy link
Owner

What OS are you using?

Connected to the Pocket over USB or via an SD card reader?

Do you remember if you “safely ejected” the SD card?

There is a download progress bar & the message saying what firmware is on the SD card should only appear once it’s confirmed the file is there.

It checks the checksum of the downloaded file against what analogue tells us it should be so it should be fairly reliable.

What I think has happened is that the OS hasn’t flushed to the SD card yet, since some will try and minimise writes to external storage and batch them up - so to Pocket Sync the file would appear to be there & complete since the OS pretends it’s done it already.

The OS should do any remaining flushing when the media is ejected, but it sounds like it hasn’t.

@kevinleguillou
Copy link
Author

I did this on MacOS Sonoma 14.3 (23D56), while connecting the Pocket with USB. I did see a download progress bar, but I think it switched to the Firmware pocket_firmware_2_4.bin is on the SD card message as soon as the download was over. So it's probably as you said, the OS said it was done but not really.
I used the B button on the Pocket to quit the SD Card mode which (I think) is basically the same as yanking the USB cable without any safe eject.

The thing is that the UI shows Firmware pocket_firmware_2_4.bin is on the SD card for 1min as it's still loading, then the debug log shows the firmware downloaded event that triggers when the file is fully written on the SD card.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants