Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin work well in non node environments #94

Open
nmantulenko opened this issue Apr 1, 2019 · 1 comment
Open

Make plugin work well in non node environments #94

nmantulenko opened this issue Apr 1, 2019 · 1 comment

Comments

@nmantulenko
Copy link

nmantulenko commented Apr 1, 2019

I use this module with react-native.
And I have to install assert lib independently to be able to work with it

Shouldn't we just put 'assert' in package.json's dependencies?

@nmantulenko nmantulenko changed the title Error: Unable to resolve module assert from node_modules/moment-opening-times/OpeningTimes.js Make plugin work well in non node environments Apr 1, 2019
@neilbmclaughlin
Copy link
Owner

Apologies for the delay in responding.

I think we probably shouldn't be using assert in the first place. It could be easily rewritten to remove it while still validating the passed parameters.

I'll make some changes with a view to raising a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants