Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment-the-first comments #1

Open
amcrabtree opened this issue Jul 31, 2021 · 0 comments
Open

Assignment-the-first comments #1

amcrabtree opened this issue Jul 31, 2021 · 0 comments

Comments

@amcrabtree
Copy link

  • Personal preference here- demultiplexing seems complicated enough that it would serve best as a standalone program instead of a function call.
  • Input and outputs are very clear, thank you.
  • I think that, if either of the indexes in R2 or R3 are low quality score, both R1 and R4 records get sent to the low quality bins. Same for N’s and index hopping.
  • Looks like there needs to be a condition for index hoping bins.
  • If writing to files, a return statement for a function call is unnecessary (only needed if you’re returning a value).
  • Indexes in R3 file are reverse complement of indexes in indexes.txt. Might be good to make a function for doing reverse complements.
  • Consider using the indexes.txt file to have something to compare the indexes against in the sequencing file. Otherwise there may be mis-sequenced indexes which will create too many output bins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant