Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate lowcode language loader for removal #248

Open
shartte opened this issue Feb 17, 2025 · 2 comments
Open

Deprecate lowcode language loader for removal #248

shartte opened this issue Feb 17, 2025 · 2 comments

Comments

@shartte
Copy link
Contributor

shartte commented Feb 17, 2025

One can now make lowcode mods by simply using the javafml language loader and not providing any java classes at all.

Once #246 is implemented, it will be much more natural to just not define a language loader at all for datapack-style mods, and that makes the lowcode loader somewhat redundant, which is why I suggest we deprecate it for removal (or outright remove it in a BC).
The guidance for modders should be: Just remove the loader + loaderversion from your neoforge.mods.toml.

There is slight overhead of creating a mod event bus even for such mods that don't have any event subscribers, but in large modpacks, datpack mods will make up a tine fraction of the overall mods, so I do not anticipate negative effects because of this.

@TelepathicGrunt
Copy link
Contributor

TelepathicGrunt commented Feb 17, 2025

Does this need to be a BC and just not treat any pre-existing mod setup as lowcode like a normal mod out of box without them needing to change?

@shartte
Copy link
Contributor Author

shartte commented Feb 17, 2025

We could translate the lowcode loader to javafml automatically and print a warning, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants