Add a hook for blocks to suppress a neighboring fluid overlay

[embeddedt]

This PR introduces a new method shouldHideAdjacentFluidFace on blocks that may be overridden to customize the logic for determining when the fluid is visually "compatible" with a neighbor (which stops the water overlay from rendering on a given face). The default implementation matches vanilla behavior.

This can be used to tweak the rendering of transparent blocks underwater (e.g. to implement the "depth glass" effect from Alex's Caves, see photo below for an example). That mod currently uses a mixin to implement the same effect; the goal of this PR is to remove the need for such a mixin.

This is #940 but with the method renamed and the patches updated for 1.21.3.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: c73344c9378ba7aa3f5c792f6c0ff64e81b96296.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.3.43-beta-pr-1690-add-fluid-face-removal
• 📦 net.neoforged:testframework:21.3.43-beta-pr-1690-add-fluid-face-removal

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1690' // https://github.com/neoforged/NeoForge/pull/1690
        url 'https://prmaven.neoforged.net/NeoForge/pr1690'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1690.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1690
cd NeoForge-pr1690
curl -L https://prmaven.neoforged.net/NeoForge/pr1690/net/neoforged/neoforge/21.3.43-beta-pr-1690-add-fluid-face-removal/mdk-pr1690.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[XFactHD]

Do you mind adding a small test?