Add a hook for blocks to suppress a neighboring fluid overlay #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embeddedt
added
rendering
Last commit published: c73344c9378ba7aa3f5c792f6c0ff64e81b96296. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1690' // https://github.com/neoforged/NeoForge/pull/1690
url 'https://prmaven.neoforged.net/NeoForge/pr1690'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
}MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1690
cd NeoForge-pr1690
curl -L https://prmaven.neoforged.net/NeoForge/pr1690/net/neoforged/neoforge/21.3.43-beta-pr-1690-add-fluid-face-removal/mdk-pr1690.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zipTo test a production environment, you can download the installer from here. |
XFactHD
requested changes
Nov 17, 2024
patches/net/minecraft/client/renderer/block/LiquidBlockRenderer.java.patch
Outdated
Show resolved
Hide resolved
patches/net/minecraft/client/renderer/block/LiquidBlockRenderer.java.patch
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/extensions/IBlockStateExtension.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/extensions/IBlockExtension.java
Outdated
Show resolved
Hide resolved
sciwhiz12
added
the
enhancement
XFactHD
approved these changes
Nov 23, 2024
|
🚀 This PR has been released as NeoForge version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new method
shouldHideAdjacentFluidFaceon blocks that may be overridden to customize the logic for determining when the fluid is visually "compatible" with a neighbor (which stops the water overlay from rendering on a given face). The default implementation matches vanilla behavior.This can be used to tweak the rendering of transparent blocks underwater (e.g. to implement the "depth glass" effect from Alex's Caves, see photo below for an example). That mod currently uses a mixin to implement the same effect; the goal of this PR is to remove the need for such a mixin.
This is #940 but with the method renamed and the patches updated for 1.21.3.