-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AttributeTemplate record public #1708
Make AttributeTemplate record public #1708
Conversation
Last commit published: 57fd4ba480223c527f0f5a2a4e31af8cf6400d21. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1708' // https://github.com/neoforged/NeoForge/pull/1708
url 'https://prmaven.neoforged.net/NeoForge/pr1708'
content {
includeModule('net.neoforged', 'neoforge')
includeModule('net.neoforged', 'testframework')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1708
cd NeoForge-pr1708
curl -L https://prmaven.neoforged.net/NeoForge/pr1708/net/neoforged/neoforge/21.3.53-beta-pr-1708-AttributeTemplatePublicity/mdk-pr1708.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that spotless didn't catch it... please use an AT for both the record and its default constructor as is the case for any access changes.
@Matyrobbrt Could you re-review this? |
🚀 This PR has been released as NeoForge version |
Allows modders to easily use the main constructor to give an Int2DoubleFunction curve to AttributeTemplate.
Closes #1691