Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AttributeTemplate record public #1708

Merged

Conversation

TelepathicGrunt
Copy link
Contributor

Allows modders to easily use the main constructor to give an Int2DoubleFunction curve to AttributeTemplate.

Closes #1691

@TelepathicGrunt TelepathicGrunt added bug A bug or error 1.21.3 Targeted at Minecraft 1.21.3 labels Nov 26, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 26, 2024

  • Publish PR to GitHub Packages

Last commit published: 57fd4ba480223c527f0f5a2a4e31af8cf6400d21.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1708' // https://github.com/neoforged/NeoForge/pull/1708
        url 'https://prmaven.neoforged.net/NeoForge/pr1708'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1708.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1708
cd NeoForge-pr1708
curl -L https://prmaven.neoforged.net/NeoForge/pr1708/net/neoforged/neoforge/21.3.53-beta-pr-1708-AttributeTemplatePublicity/mdk-pr1708.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

Copy link
Member

@Matyrobbrt Matyrobbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that spotless didn't catch it... please use an AT for both the record and its default constructor as is the case for any access changes.

@marchermans
Copy link
Contributor

@Matyrobbrt Could you re-review this?

@Matyrobbrt Matyrobbrt merged commit 0836a18 into neoforged:1.21.x Nov 28, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.3.51-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull #1334 Broke ATs and made it impossible to access a vanilla class
4 participants