pageserver: fix race cleaning up timeline files when shut down during bootstrap #10532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
changed the title
6 tasks
jcsp
force-pushed
the
jcsp/issue-10389-cleanup-race
branch
from
e0c6856 to
e27ba6f
Compare
7414 tests run: 7063 passed, 0 failed, 351 skipped (full report)Flaky tests (7)Postgres 17
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
65b60cb at 2025-01-29T22:18:53.197Z :recycle: |
|
the |
jcsp
force-pushed
the
jcsp/issue-10389-cleanup-race
branch
from
e27ba6f to
d5c8e08
Compare
Yeah, the issue was more pervasive than I realised, so once I made the drop() strict about checking for shutdown, other things started failing. Reworked this to more reliably enforce rules about shutdown, by wrapping everything in an UninitializedTimeline.write() helper that spawns flush loop but also ensures it gets shut down on failures. |
jcsp
force-pushed
the
jcsp/issue-10389-cleanup-race
branch
2 times, most recently
from
ee2a0c2 to
d837aa7
Compare
jcsp
force-pushed
the
jcsp/issue-10389-cleanup-race
branch
from
d837aa7 to
f032330
Compare
skyzh
approved these changes
Jan 30, 2025
winter-loo
pushed a commit
to winter-loo/neon
that referenced
this pull request
Feb 4, 2025
… bootstrap (neondatabase#10532) ## Problem Timeline bootstrap starts a flush loop, but doesn't reliably shut down the timeline (incl. waiting for flush loop to exit) before destroying UninitializedTimeline, and that destructor tries to clean up local storage. If local storage is still being written to, then this is unsound. Currently the symptom is that we see a "Directory not empty" error log, e.g. https://neon-github-public-dev.s3.amazonaws.com/reports/main/12966756686/index.html#testresult/5523f7d15f46f7f7/retries ## Summary of changes - Move fallible IO part of bootstrap into a function (notably, this is fallible in the case of the tenant being shut down while creation is happening) - When that function returns an error, call shutdown() on the timeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Timeline bootstrap starts a flush loop, but doesn't reliably shut down the timeline (incl. waiting for flush loop to exit) before destroying UninitializedTimeline, and that destructor tries to clean up local storage. If local storage is still being written to, then this is unsound.
Currently the symptom is that we see a "Directory not empty" error log, e.g. https://neon-github-public-dev.s3.amazonaws.com/reports/main/12966756686/index.html#testresult/5523f7d15f46f7f7/retries
Summary of changes