BUGFIX: Accept a string as second parameter of the slot method

[daniellienert]

Fixes: #42

[daniellienert]

@kdambekalns, currently testing against Neos 7. I remember that there have been changes in Signal/Slot information passing. May that be related?

[kdambekalns]

Hah, this seems to be a prime example of why the "maybe this passes a string" idea was bad. My guess: deactivating the signal information in the connecion is the better fix!

[kdambekalns]

… which you seem to do in

content-repository-search/Classes/Package.php

Line 59 in 895ca8f

$bootstrap->getSignalSlotDispatcher()->connect(Node::class, 'nodeRemoved', Indexer\NodeIndexingManager::class, 'removeNode', false);

already!?

Also, #42 is weird, the signal information is passed twice?!

[daniellienert]

@kdambekalns, wild guess from looking at it:

there is a loop over the slots in dispatch and signal information is added to the $signalArguments[] array on every loop:
https://github.com/neos/flow-development-collection/blob/master/Neos.Flow/Classes/SignalSlot/Dispatcher.php#L182

As the common nodeAdded signal is used. Might it be that $passSignalInformation is set to true at two other connections to that signal and so they are passed here as well?

[albe]

https://github.com/neos/flow-development-collection/blob/master/Neos.Flow/Classes/SignalSlot/Dispatcher.php#L182

That line is indeed a bug! The $signalArguments array needs to be reset to the initial value passed into the dispatch for every iteration.

Also, this is handled correctly up to 6.3 so it is a regression: https://github.com/neos/flow-development-collection/blob/6.3/Neos.Flow/Classes/SignalSlot/Dispatcher.php#L110

[albe]

Should be fixed with neos/flow-development-collection#2362 so this can then be closed. Sorry that change in behaviour went by unnoticed!

[kdambekalns]

I still think this is wrong. The parameter must be a Workspace (or null), but never something else. So removing the type does not solve anything!

[daniellienert]

Hey @kdambekalns, no worries. Just fixed it here to get the project going. The fix in Flow makes this unnecessary.