From 5ff21badf8ccbd01a6ca0011e51b077d7e31522a Mon Sep 17 00:00:00 2001 From: Daniel Lienert Date: Thu, 17 Dec 2020 09:15:04 +0100 Subject: [PATCH 1/2] BUGFIX: Accept a string as second parameter of the slot method --- Classes/Indexer/NodeIndexingManager.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Classes/Indexer/NodeIndexingManager.php b/Classes/Indexer/NodeIndexingManager.php index e3e9839..1124b69 100644 --- a/Classes/Indexer/NodeIndexingManager.php +++ b/Classes/Indexer/NodeIndexingManager.php @@ -97,10 +97,10 @@ public function indexNode(NodeInterface $node, Workspace $targetWorkspace = null * Schedule a node for removal of the index * * @param NodeInterface $node - * @param Workspace $targetWorkspace In case this is triggered during publishing, a Workspace will be passed in + * @param mixed $targetWorkspace In case this is triggered during publishing, a Workspace will be passed in. Otherwise a signal information string can be found in the second argument. * @return void */ - public function removeNode(NodeInterface $node, Workspace $targetWorkspace = null) + public function removeNode(NodeInterface $node, $targetWorkspace = null): void { $this->nodesToBeIndexed->detach($node); $this->nodesToBeRemoved->attach($node); From dd572317948b3bf0b64d933d0ca46a2c9ecb728e Mon Sep 17 00:00:00 2001 From: Daniel Lienert Date: Mon, 21 Dec 2020 10:08:54 +0100 Subject: [PATCH 2/2] TASK: Also remove the type in indexNode --- Classes/Indexer/NodeIndexingManager.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/Indexer/NodeIndexingManager.php b/Classes/Indexer/NodeIndexingManager.php index 1124b69..7c1d76a 100644 --- a/Classes/Indexer/NodeIndexingManager.php +++ b/Classes/Indexer/NodeIndexingManager.php @@ -79,7 +79,7 @@ public function injectSettings(array $settings) * @param Workspace $targetWorkspace In case this is triggered during publishing, a Workspace will be passed in * @return void */ - public function indexNode(NodeInterface $node, Workspace $targetWorkspace = null) + public function indexNode(NodeInterface $node, $targetWorkspace = null) { // if this is triggered via afterNodePublishing, it could be a deletion, check and handle if ($node->isRemoved() && $targetWorkspace !== null && $targetWorkspace->getBaseWorkspace() === null) {