Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Accept a string as second parameter of the slot method #43

Closed
wants to merge 2 commits into from
Closed

BUGFIX: Accept a string as second parameter of the slot method #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ff21ba
BUGFIX: Accept a string as second parameter of the slot method
daniellienert Dec 17, 2020
dd57231
TASK: Also remove the type in indexNode
daniellienert Dec 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Classes/Indexer/NodeIndexingManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ public function injectSettings(array $settings)
* @param Workspace $targetWorkspace In case this is triggered during publishing, a Workspace will be passed in
* @return void
*/
public function indexNode(NodeInterface $node, Workspace $targetWorkspace = null)
public function indexNode(NodeInterface $node, $targetWorkspace = null)
{
// if this is triggered via afterNodePublishing, it could be a deletion, check and handle
if ($node->isRemoved() && $targetWorkspace !== null && $targetWorkspace->getBaseWorkspace() === null) {
Expand All @@ -97,10 +97,10 @@ public function indexNode(NodeInterface $node, Workspace $targetWorkspace = null
* Schedule a node for removal of the index
*
* @param NodeInterface $node
* @param Workspace $targetWorkspace In case this is triggered during publishing, a Workspace will be passed in
* @param mixed $targetWorkspace In case this is triggered during publishing, a Workspace will be passed in. Otherwise a signal information string can be found in the second argument.
* @return void
*/
public function removeNode(NodeInterface $node, Workspace $targetWorkspace = null)
public function removeNode(NodeInterface $node, $targetWorkspace = null): void
{
$this->nodesToBeIndexed->detach($node);
$this->nodesToBeRemoved->attach($node);
Expand Down