Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BitBucket regex #108

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix BitBucket regex #108

wants to merge 4 commits into from

Conversation

mathrick
Copy link

@mathrick mathrick commented Sep 26, 2024 •
edited
Loading

Description

This fixes the BitBucket regex so username@ is not required, and adds bitbucket.com as a recognised domain.

References

Fixes #107

Checklist

  • Code lint checked via inv lint
  • Tests added

@mathrick
Copy link
Author

Updated the PR, thanks @yarikoptic for the review!

Please note that I also had to fix the way platform defaults are applied during parsing; the old code effectively discarded any defaults that were defined. Since this is required to get the tests passing, I think it belongs in this PR, but if you'd like me to split it out into its own PR, I can do that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BitBucket URLs are detected as gitlab
2 participants
@mathrick @yarikoptic