Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not this be a branch? #55

Open
feliam opened this issue May 3, 2023 · 1 comment
Open

Should not this be a branch? #55

feliam opened this issue May 3, 2023 · 1 comment

Comments

@feliam
Copy link

feliam commented May 3, 2023

    from giturlparse import parse as giturlparse
    p = giturlparse("https://github.com/nephila/giturlparse/tree/master/changes")
    print (p.branch, p.path)
    assert p.branch == "master"
    assert p.path == "changes"
@protoroto
Copy link
Member

@feliam The url you're referring to in test_parse.py is https://github.com/nephila/giturlparse/blob/master/giturlparse/github.py , but you did test https://github.com/nephila/giturlparse/tree/master/changes , that is a different url.

Or am I missing something here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants