Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rejection sampling broken #3530

Open
gtangg12 opened this issue Nov 23, 2024 · 0 comments
Open

Rejection sampling broken #3530

gtangg12 opened this issue Nov 23, 2024 · 0 comments

Comments

@gtangg12
Copy link
Contributor

gtangg12 commented Nov 23, 2024

Hi, I believe

chosen_indices_validity = mask.squeeze()[c, y, x].bool()

does not work for batch size 1 e.g. evaluation sampling? Currently, my eval mask has shape torch.Size([1, 640, 480, 1]), if that's correct (since I am using a custom datamanger).

The other methods seem to use

mask[..., 0]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant