Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cancel_invoice] send_payment will cause node2 return Musig2VerifyError when invoice cancel #305

Open
gpBlockchain opened this issue Nov 13, 2024 · 4 comments · May be fixed by #341
Open

Comments

@gpBlockchain
Copy link
Contributor

  1. node2 new_invoice
  2. node2 cancel_invoice
  3. node1 send_payment
    node2 return Musig2VerifyError
  2024-11-13T14:39:12.254834Z ERROR fnn::fiber::channel: Error while processing channel message: Musig2VerifyError(BadSignature)

node2.log
node.log

@gpBlockchain
Copy link
Contributor Author

The same thing will happen when the invoice time approaches expiry

@chenyukang
Copy link
Collaborator

The same thing will happen when the invoice time approaches expiry

which branch are you running, the expiry check logic haven't been merged, it's on chenyukang#2

@gpBlockchain
Copy link
Contributor Author

The same thing will happen when the invoice time approaches expiry

which branch are you running, the expiry check logic haven't been merged, it's on chenyukang#2

main branch

@chenyukang
Copy link
Collaborator

https://github.com/chenyukang/fiber/tree/debugging-sig-issue
this branch can reproduce the issue, it's the different cause, but I believe it's the same kind of issue for Musig2VerifyError.

run command : npm exec -- @usebruno/[email protected] run e2e/router-pay -r --env test

check the logs.

@chenyukang chenyukang linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants