Skip to content
This repository has been archived by the owner on Aug 13, 2021. It is now read-only.

Typo in GtR table name #206

Closed
bishax opened this issue Dec 9, 2019 · 7 comments · Fixed by #283
Closed

Typo in GtR table name #206

bishax opened this issue Dec 9, 2019 · 7 comments · Fixed by #283
Assignees
Labels
invalid This doesn't seem right

Comments

@bishax
Copy link
Contributor

bishax commented Dec 9, 2019

https://github.com/nestauk/nesta/blob/5d73c749411d58c2c354b24421320da523d1e99d/nesta/core/orms/gtr_orm.py#L295

@bishax bishax added the invalid This doesn't seem right label Dec 9, 2019
@bishax
Copy link
Contributor Author

bishax commented Dec 9, 2019

@kstathou what is this table used for?

@kstathou
Copy link
Contributor

kstathou commented Dec 9, 2019

To store the document ID, the cluster number and the probability of being in that cluster of a GtR project.

It stores the outcome of the clustering_task.py

@bishax
Copy link
Contributor Author

bishax commented Dec 9, 2019

Ok, and does any code depend on this table that you are aware of?

@kstathou
Copy link
Contributor

kstathou commented Dec 9, 2019

This tiny bit here: https://github.com/nestauk/nesta/blob/154_clio_clusters/nesta/core/routines/embed_topics/clustering_task.py#L86-L88

So changing the __table_name__ shouldn't break anything.

@bishax
Copy link
Contributor Author

bishax commented Dec 9, 2019

Ok, and is there a reason that this is only in dev and not in production?

@kstathou
Copy link
Contributor

kstathou commented Dec 9, 2019

I haven't run it on the full dataset. Joel also added #203 so it might be better to fix that first and then run it on production.

@jaklinger
Copy link
Contributor

this will be address alongside #270

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants