Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi PR Request (upgrades in azure library) #129

Open
Setitch opened this issue Jun 30, 2020 · 3 comments
Open

Semi PR Request (upgrades in azure library) #129

Setitch opened this issue Jun 30, 2020 · 3 comments
Assignees

Comments

@Setitch
Copy link

Setitch commented Jun 30, 2020

I'm submitting a...


[ ] Regression 
[ ] Bug report
[X] Feature request
[X] Question and example answer
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

Nest version is old, @azure/storage-blob is old.
Cannot use key, connectionString nor any new authorization method.
Cannot use delete, download methods of library (they are nor written)

Expected behavior

Minimal reproduction of the problem with instructions

just download this version and all problems ocures.

What is the motivation / use case for changing the behavior?

Upgrade versions and add more functionality

##Example of fix
I rewrote some files - tests works - as i needs stated features asap. Only one thing i got (after upgrading) is error of:

TypeError: Cannot read property 'kind' of undefined

    |     const ms = node.moduleSpecifier;
    |     let modulePath;
>  |     switch (ms.kind) {
which im not able to even understand (i mean i never ever used such features of node).

So what im asking is to look at my repo and maybe incorporate what you thing is wrote ok or give me hints how to fix the issue i have now (which forbids building the library for npm).

Link to repo: https://github.com/Setitch/azure-storage

@manekinekko
Copy link
Collaborator

manekinekko commented Nov 3, 2020

@Setitch would you mind opening a PR (even if it's incomplete)? We can review it together.

manekinekko added a commit that referenced this issue Nov 9, 2020
@manekinekko manekinekko self-assigned this Nov 9, 2020
manekinekko added a commit that referenced this issue Nov 9, 2020
manekinekko added a commit that referenced this issue Nov 9, 2020
- NestJS 7 support
- Upgrade Azure blob storage
- Add support for connection string access

Closes #7 #129 #127
@Setitch
Copy link
Author

Setitch commented Dec 5, 2020

Thank you for answering, i made the PR for your review. I use the version from it on production project already (needed progress bars for upload/download) and also deleting and some other options that was lacking from nestjs version.
What is not working in my version are tests and after some time i stopped working on them as sadly not much time and i do not really get some of them (like error i got, i totally dont get it)

@Setitch
Copy link
Author

Setitch commented Dec 14, 2020

@manekinekko When you would have time to review it? So we can do that together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants