Required meta is hardcoded to true when implicit params mapping to meta rather evaluating it to param.isOptional()

[rsirs]

swagger/lib/explorers/api-parameters.explorer.ts

Line 83 in 79fa84a

required: true

For example:

create(@Body() body: ReqBody, @Query('xyz') xyz?: ReqQueryParam) {
}

Here query param XYZ is interpreted as required even though it is optional param because of hardcoded required=true. Now, To make it optional we have to explicitly define

@ApiImplicitQuery({
    name: 'xyz',
    required: false,
  })
create(@Body() body: ReqBody, @Query('xyz') xyz?: ReqQueryParam) {
}

if we make this something like required=!isOptional(param) we don't need to add addition ApiImplicitQuery annotation for required field.

Any thought on that?

[kamilmysliwiec]

Duplicate of #30

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.