Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix For Loading Yaml File Content and Inline Hashes #271

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix For Loading Yaml File Content and Inline Hashes #271

wants to merge 2 commits into from

Conversation

mtarking
Copy link
Collaborator

Related Issue(s)

Resolves #270

Related Collection Role

  • cisco.nac_dc_vxlan.validate
  • cisco.nac_dc_vxlan.dtc.create
  • cisco.nac_dc_vxlan.dtc.deploy
  • cisco.nac_dc_vxlan.dtc.remove
  • other

Related Data Model Element

  • vxlan.global
  • vxlan.topology
  • vxlan.underlay
  • vxlan.overlay_services
  • vxlan.overlay_extensions
  • vxlan.policy
  • defaults.vxlan
  • other

Proposed Changes

The proposed changes strips the --- and ... of YAML files.
Additionally, the usage of Ansible's to_nice_yaml is removed as it's unnecessary.

Test Notes

Tested with .cfg, .yml, and inline data.
Can discuss in standup.

Cisco NDFC Version

12.2.2

Checklist

  • Latest commit is rebased from develop with merge conflicts resolved
  • New or updates to documentation has been made accordingly
  • Assigned the proper reviewers

@mtarking mtarking self-assigned this Jan 28, 2025
@mtarking mtarking added the wip work-in-progress label Jan 28, 2025
devegupt
devegupt reviewed Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@devegupt devegupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tested with the YAML as below and it works which was not working without Fix.

---
CONF: |-
  feature grpc
  feature grpc-tls

@mtarking mtarking added ready for review PR Ready for Review and removed wip work-in-progress labels Jan 29, 2025
@mtarking mtarking requested a review from devegupt February 1, 2025 11:06
@mtarking mtarking marked this pull request as ready for review February 3, 2025 13:16
@mtarking mtarking requested a review from a team as a code owner February 3, 2025 13:16
devegupt
devegupt approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@devegupt devegupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested the this fix, it works well.

juburnet
juburnet approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@juburnet juburnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me with yaml --- and ...
On the develop branch it errors out, and this fix processes the policy properly and the content of the policy is correct on the ndfc after deploy.

@mtarking mtarking mentioned this pull request Feb 7, 2025
Open
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devegupt devegupt devegupt approved these changes

@juburnet juburnet juburnet approved these changes

@peter8498 peter8498 Awaiting requested review from peter8498

At least 1 approving review is required to merge this pull request.

Assignees

@mtarking mtarking

Labels
ready for review PR Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bring Your Own Policy Loads Beginning and End of YAML Files
3 participants
@mtarking @devegupt @juburnet