Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[management] Add integration test for the API endpoints #2936

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

pascal-fischer
Copy link
Contributor

@pascal-fischer pascal-fischer commented Nov 22, 2024

Describe your changes

This PR adds integration tests to test the full flow from API endpoint down to the store layer back up to the API response and the peers update message.

Issue ticket number and link

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@pascal-fischer pascal-fischer changed the title [management] Add component test for the API endpoints [management] Add integration test for the API endpoints Nov 22, 2024
Copy link

sonarcloud bot commented Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 19 changed files in this pull request and generated no suggestions.

Files not reviewed (13)
  • management/server/http/testdata/setup_keys.sql: Language not supported
  • management/server/http/setupkeys_handler_test.go: Evaluated as low risk
  • relay/client/picker_test.go: Evaluated as low risk
  • management/server/account_test.go: Evaluated as low risk
  • management/server/geolocation/geolocation.go: Evaluated as low risk
  • management/server/management_test.go: Evaluated as low risk
  • management/server/grpcserver.go: Evaluated as low risk
  • management/server/jwtclaims/jwtValidator.go: Evaluated as low risk
  • management/server/geolocation/geolocation_test.go: Evaluated as low risk
  • management/server/http/geolocations_handler.go: Evaluated as low risk
  • management/server/http/posture_checks_handler.go: Evaluated as low risk
  • management/server/http/posture_checks_handler_test.go: Evaluated as low risk
  • management/server/user_test.go: Evaluated as low risk
Comments skipped due to low confidence (2)

management/server/account.go:170

  • [nitpick] The variable name 'geo' is ambiguous. It should be renamed to 'geolocationManager' for consistency.
geo                  geolocation.Geolocation

management/server/account.go:1044

  • [nitpick] The variable name 'geo' is ambiguous. It should be renamed to 'geolocationManager' for consistency.
geo geolocation.Geolocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant