Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for handling disconnected graphs #279

Open
sdmccabe opened this issue Jan 10, 2020 · 0 comments
Open

Test for handling disconnected graphs #279

sdmccabe opened this issue Jan 10, 2020 · 0 comments
Assignees
@sdmccabe
Labels
enhancement New feature or request

Comments

@sdmccabe
Copy link
Collaborator

We should have some handling for disconnected graphs in our distances. Some distances explicitly don't work with disconnected graphs. I think these should either:

  1. raise a ValueError immediately, or
  2. return np.nan and a consistent warning of some sort.
@sdmccabe sdmccabe added the enhancement New feature or request label Jan 10, 2020
@sdmccabe sdmccabe self-assigned this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdmccabe sdmccabe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sdmccabe