Improved setup.py and potentially fixed issue 6 #12
Conversation
|
Thanks so much for your help with this! You've achieved precisely what I wanted the setup.py to do. This is a big help. Thanks again for your help! |
|
Hmm... after an attempt to use the new setup.py file on a Mac 10.7.4 machine, I discovered that the setup.py has the old problem due to Distribute not being configured properly on my system. While I could change this, my inclination is to stick with a distribution system that is going to work on the majority of systems without any additional effort. I'll slate incorporating Distribute by 1.0, but I don't want to switch things on the userbase right now. In the meantime, I'm commenting out the modification you made for later incorporation - since this certainly is the only way of getting cython and dependencies working right now. Thanks so much for your contributions - please keep contributing! |
|
Hmm, I would have thought that the Perhaps a 1.0-dev branch might be useful in this case? This way further developments can be made independently and newcomers can be pointed to that branch to get an install procedure that has the desired features (if they are using a version of Mac OS X > 10.7.4 or if they are ready to make more configurations). Thanks for the support! |
Hello,
Zenlib still had some issues building on Ubuntu so I worked on the setup.py script (see below) and added installation instructions in the repository's readme.md so that interested parties can install the library quickly.
The original issue: zenlib depends on networkx but networkx wasn't listed in the install instructions nor was
setup.pyfetching any dependencies. I hypothesize that the commenting out of theinstall_requireswas originally due to setuptools and cython's incompatibility which led to the use ofdistutils.coreas a stop-gap. To fix this I've clearly indicated the dependency on distribute which fixes this issue. Dependencies can now be listed again! It seems like distribute is getting traction so I don't think it is such a far-fetched solution.I also believe this fixes #6 as the problem there was due to missing .c files which would not have been built by the
setup.pyscript using regular setuptools.Hopefully this makes sense and helps make zenlib easier to install.