Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetricLogger fails if outputs are None. #48

Open
arseniybelkov opened this issue Aug 19, 2023 · 0 comments
Open

MetricLogger fails if outputs are None. #48

arseniybelkov opened this issue Aug 19, 2023 · 0 comments
Labels
bug Something isn't working callback Issues related to experiment callbacks questionable It is not clear whether feature or fix is needed. Should be discussed.

Comments

@arseniybelkov
Copy link
Member

If in validation step outputs are None, MetricLogger fails.

  File "~/thunder/thunder/callbacks/metric_logger.py", line 166, in evaluate_batch
    if len(outputs) != 2:
       ^^^^^^^^^^^^
TypeError: object of type 'NoneType' has no len()
@arseniybelkov arseniybelkov added bug Something isn't working callback Issues related to experiment callbacks questionable It is not clear whether feature or fix is needed. Should be discussed. labels Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working callback Issues related to experiment callbacks questionable It is not clear whether feature or fix is needed. Should be discussed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arseniybelkov