Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for NIR edge dimensionality #4

Closed
Jegp opened this issue Jul 5, 2023 · 1 comment
Closed

Add tests for NIR edge dimensionality #4

Jegp opened this issue Jul 5, 2023 · 1 comment

Comments

@Jegp
Copy link
Collaborator

Jegp commented Jul 5, 2023

Every outgoing edge must have the same dimensionality as the corresponding incoming edge. We can ensure that by checking the edges when the NIR object is constructed. Perhaps by __post_init__?
@stevenabreu7
Copy link
Collaborator

the function for this is implemented in #59, which can be called on every graph. currently, it is not enforced, but this is suggested in PR #61 so I will close this issue

@stevenabreu7 stevenabreu7 mentioned this issue Oct 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jegp @stevenabreu7