-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding manual centerlines #204
Comments
went through the subjects and fixed the centerlines. if @naga-karthik you want to quickly check a few random sub to confirm it's okay? thanks! |
I checked a few more subjects and lgtm! So, the latest branch (with the fixed centrelines) is |
@jcohenadad could you please merge the latest updates from the branch that's mentioned in this comment? |
@naga-karthik @kiristern thanks for looking into this! can you please work on a single branch and update the issue so there is no confusion as to what branch to use (two branches are listed in this issue)-- thanks! |
currently reviewing
|
mistake on file location: sci-zurich/derivatives/labels/sub-zh05/sub-zh05_ses-01_acq-sag_T2w_centerline-manual.csv |
i rm all csv files, as they should not have been incl. and fixed |
@kiristern I reviewed 9eab8de77d132a886c3e0b091a4e100e990751f8:
|
@kiristern @naga-karthik can you please delete the branch |
My mistake, thanks for catching! i moved it to the appropriate derivative folder and also reverted the .csv files because @naga-karthik suggested they could be used for training a regression model |
@jcohenadad we were having some issues pulling the changes so I created a new branch I'm not going to delete the |
Sure, if it works on your end, please merge it to master @jcohenadad ! I'll do the surgery on the branch by discussing with @mguaypaq next week. Seems like the problem is specific to me. |
Just to make sure, the latest branch is |
Just an update: I think we've isolated the problem, which is that |
@jcohenadad if not already done, can you please merge the branch |
not done-- will do-- on my todo list-- other priorities |
fccc609aeb3336e8d6978306cb0b24db7d825eb3 (HEAD -> master, origin/master, origin/HEAD) modified segmentation |
Bringing it up-to-date: Terminal outputjulien-macbook:~/data.neuro/sci-zurich $ git merge master
Merge made by the 'recursive' strategy.
derivatives/labels/sub-zh56/ses-01/anat/sub-zh56_ses-01_acq-sag_T2w_lesion-manual.json | 2 +-
derivatives/labels/sub-zh56/ses-01/anat/sub-zh56_ses-01_acq-sag_T2w_lesion-manual.nii.gz | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
julien-macbook:~/data.neuro/sci-zurich $ git pull && git annex sync --no-content
hint: Pulling without specifying how to reconcile divergent branches is
hint: discouraged. You can squelch this message by running one of the following
hint: commands sometime before your next pull:
hint:
hint: git config pull.rebase false # merge (the default strategy)
hint: git config pull.rebase true # rebase
hint: git config pull.ff only # fast-forward only
hint:
hint: You can replace "git config" with "git config --global" to set a default
hint: preference for all repositories. You can also pass --rebase, --no-rebase,
hint: or --ff-only on the command line to override the configured default per
hint: invocation.
Already up to date.
commit
On branch ks/troubleshoot
Your branch is ahead of 'origin/ks/troubleshoot' by 2 commits.
(use "git push" to publish your local commits)
nothing to commit, working tree clean
ok
pull origin
ok
push origin
Enumerating objects: 10, done.
Counting objects: 100% (10/10), done.
Delta compression using up to 12 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (4/4), 405 bytes | 405.00 KiB/s, done.
Total 4 (delta 2), reused 0 (delta 0), pack-reused 0
To data.neuro.polymtl.ca:datasets/sci-zurich
* [new branch] ks/troubleshoot -> synced/ks/troubleshoot
ok
Looking good: Terminal outputjulien-macbook:~/data.neuro/sci-zurich $ git diff --name-only master..HEAD
derivatives/labels/sub-zh04/ses-01/anat/sub-zh04_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh04/ses-01/anat/sub-zh04_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh05/ses-01/anat/sub-zh05_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh05/ses-01/anat/sub-zh05_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh06/ses-01/anat/sub-zh06_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh06/ses-01/anat/sub-zh06_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh06/ses-02/anat/sub-zh06_ses-02_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh06/ses-02/anat/sub-zh06_ses-02_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh09/ses-01/anat/sub-zh09_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh09/ses-01/anat/sub-zh09_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh11/ses-01/anat/sub-zh11_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh11/ses-01/anat/sub-zh11_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh11/ses-02/anat/sub-zh11_ses-02_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh11/ses-02/anat/sub-zh11_ses-02_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh14/ses-01/anat/sub-zh14_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh14/ses-01/anat/sub-zh14_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh16/ses-01/anat/sub-zh16_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh16/ses-01/anat/sub-zh16_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh22/ses-01/anat/sub-zh22_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh22/ses-01/anat/sub-zh22_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh36/ses-01/anat/sub-zh36_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh36/ses-01/anat/sub-zh36_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh37/ses-01/anat/sub-zh37_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh37/ses-01/anat/sub-zh37_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh48/ses-01/anat/sub-zh48_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh48/ses-01/anat/sub-zh48_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh49/ses-01/anat/sub-zh49_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh49/ses-01/anat/sub-zh49_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh68/ses-01/anat/sub-zh68_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh68/ses-01/anat/sub-zh68_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh69/ses-01/anat/sub-zh69_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh69/ses-01/anat/sub-zh69_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh77/ses-01/anat/sub-zh77_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh77/ses-01/anat/sub-zh77_ses-01_acq-sag_T2w_centerline-manual.nii.gz
derivatives/labels/sub-zh78/ses-01/anat/sub-zh78_ses-01_acq-sag_T2w_centerline-manual.csv
derivatives/labels/sub-zh78/ses-01/anat/sub-zh78_ses-01_acq-sag_T2w_centerline-manual.nii.gz
|
Convenient script for QCing (replace 04 05 by start end):
|
merged and cleaned up: Terminal outputjulien-macbook:~/data.neuro/sci-zurich $ git merge ks/troubleshoot
Updating fccc609..9486a83
Fast-forward
derivatives/labels/sub-zh04/ses-01/anat/sub-zh04_ses-01_acq-sag_T2w_centerline-manual.csv | 422 ++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh04/ses-01/anat/sub-zh04_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh05/ses-01/anat/sub-zh05_ses-01_acq-sag_T2w_centerline-manual.csv | 308 ++++++++++++++++++++++++++++
derivatives/labels/sub-zh05/ses-01/anat/sub-zh05_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh06/ses-01/anat/sub-zh06_ses-01_acq-sag_T2w_centerline-manual.csv | 464 +++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh06/ses-01/anat/sub-zh06_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh06/ses-02/anat/sub-zh06_ses-02_acq-sag_T2w_centerline-manual.csv | 511 +++++++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh06/ses-02/anat/sub-zh06_ses-02_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh09/ses-01/anat/sub-zh09_ses-01_acq-sag_T2w_centerline-manual.csv | 409 +++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh09/ses-01/anat/sub-zh09_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh11/ses-01/anat/sub-zh11_ses-01_acq-sag_T2w_centerline-manual.csv | 511 +++++++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh11/ses-01/anat/sub-zh11_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh11/ses-02/anat/sub-zh11_ses-02_acq-sag_T2w_centerline-manual.csv | 511 +++++++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh11/ses-02/anat/sub-zh11_ses-02_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh14/ses-01/anat/sub-zh14_ses-01_acq-sag_T2w_centerline-manual.csv | 447 ++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh14/ses-01/anat/sub-zh14_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh16/ses-01/anat/sub-zh16_ses-01_acq-sag_T2w_centerline-manual.csv | 510 +++++++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh16/ses-01/anat/sub-zh16_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh22/ses-01/anat/sub-zh22_ses-01_acq-sag_T2w_centerline-manual.csv | 447 ++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh22/ses-01/anat/sub-zh22_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh36/ses-01/anat/sub-zh36_ses-01_acq-sag_T2w_centerline-manual.csv | 375 ++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh36/ses-01/anat/sub-zh36_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh37/ses-01/anat/sub-zh37_ses-01_acq-sag_T2w_centerline-manual.csv | 481 +++++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh37/ses-01/anat/sub-zh37_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh48/ses-01/anat/sub-zh48_ses-01_acq-sag_T2w_centerline-manual.csv | 761 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh48/ses-01/anat/sub-zh48_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh49/ses-01/anat/sub-zh49_ses-01_acq-sag_T2w_centerline-manual.csv | 372 +++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh49/ses-01/anat/sub-zh49_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh68/ses-01/anat/sub-zh68_ses-01_acq-sag_T2w_centerline-manual.csv | 366 +++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh68/ses-01/anat/sub-zh68_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh69/ses-01/anat/sub-zh69_ses-01_acq-sag_T2w_centerline-manual.csv | 447 ++++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh69/ses-01/anat/sub-zh69_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh77/ses-01/anat/sub-zh77_ses-01_acq-sag_T2w_centerline-manual.csv | 340 ++++++++++++++++++++++++++++++
derivatives/labels/sub-zh77/ses-01/anat/sub-zh77_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
derivatives/labels/sub-zh78/ses-01/anat/sub-zh78_ses-01_acq-sag_T2w_centerline-manual.csv | 442 +++++++++++++++++++++++++++++++++++++++
derivatives/labels/sub-zh78/ses-01/anat/sub-zh78_ses-01_acq-sag_T2w_centerline-manual.nii.gz | 1 +
36 files changed, 8142 insertions(+)
create mode 100644 derivatives/labels/sub-zh04/ses-01/anat/sub-zh04_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh04/ses-01/anat/sub-zh04_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh05/ses-01/anat/sub-zh05_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh05/ses-01/anat/sub-zh05_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh06/ses-01/anat/sub-zh06_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh06/ses-01/anat/sub-zh06_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh06/ses-02/anat/sub-zh06_ses-02_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh06/ses-02/anat/sub-zh06_ses-02_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh09/ses-01/anat/sub-zh09_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh09/ses-01/anat/sub-zh09_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh11/ses-01/anat/sub-zh11_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh11/ses-01/anat/sub-zh11_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh11/ses-02/anat/sub-zh11_ses-02_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh11/ses-02/anat/sub-zh11_ses-02_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh14/ses-01/anat/sub-zh14_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh14/ses-01/anat/sub-zh14_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh16/ses-01/anat/sub-zh16_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh16/ses-01/anat/sub-zh16_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh22/ses-01/anat/sub-zh22_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh22/ses-01/anat/sub-zh22_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh36/ses-01/anat/sub-zh36_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh36/ses-01/anat/sub-zh36_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh37/ses-01/anat/sub-zh37_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh37/ses-01/anat/sub-zh37_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh48/ses-01/anat/sub-zh48_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh48/ses-01/anat/sub-zh48_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh49/ses-01/anat/sub-zh49_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh49/ses-01/anat/sub-zh49_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh68/ses-01/anat/sub-zh68_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh68/ses-01/anat/sub-zh68_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh69/ses-01/anat/sub-zh69_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh69/ses-01/anat/sub-zh69_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh77/ses-01/anat/sub-zh77_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh77/ses-01/anat/sub-zh77_ses-01_acq-sag_T2w_centerline-manual.nii.gz
create mode 100644 derivatives/labels/sub-zh78/ses-01/anat/sub-zh78_ses-01_acq-sag_T2w_centerline-manual.csv
create mode 100644 derivatives/labels/sub-zh78/ses-01/anat/sub-zh78_ses-01_acq-sag_T2w_centerline-manual.nii.gz
julien-macbook:~/data.neuro/sci-zurich $ git push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To data.neuro.polymtl.ca:datasets/sci-zurich
fccc609..9486a83 master -> master
julien-macbook:~/data.neuro/sci-zurich $ git branch -d ks/troubleshoot
Deleted branch ks/troubleshoot (was 9486a83).
julien-macbook:~/data.neuro/sci-zurich $ git push origin :ks/troubleshoot
To data.neuro.polymtl.ca:datasets/sci-zurich
- [deleted] ks/troubleshoot
|
Additional cleanup Terminal outputjulien-macbook:~/data.neuro/sci-zurich $ gb
git-annex
ks/centerlines
* master
synced/ks/centerlines
synced/ks/troubleshoot
synced/master
julien-macbook:~/data.neuro/sci-zurich $ git branch -d ks/centerlines
warning: deleting branch 'ks/centerlines' that has been merged to
'refs/remotes/origin/ks/centerlines', but not yet merged to HEAD.
Deleted branch ks/centerlines (was 8d79a4b).
julien-macbook:~/data.neuro/sci-zurich $ git push origin :ks/centerlines
To data.neuro.polymtl.ca:datasets/sci-zurich
- [deleted] ks/centerlines
julien-macbook:~/data.neuro/sci-zurich $ git branch -d synced/ks/centerlines
Deleted branch synced/ks/centerlines (was fbfdde7).
julien-macbook:~/data.neuro/sci-zurich $ git push origin :synced/ks/centerlines
To data.neuro.polymtl.ca:datasets/sci-zurich
- [deleted] synced/ks/centerlines
julien-macbook:~/data.neuro/sci-zurich $ git branch -d synced/ks/troubleshoot
Deleted branch synced/ks/troubleshoot (was 9486a83).
julien-macbook:~/data.neuro/sci-zurich $ git push origin :synced/ks/troubleshoot
To data.neuro.polymtl.ca:datasets/sci-zurich
- [deleted] synced/ks/troubleshoot
julien-macbook:~/data.neuro/sci-zurich $ gb
git-annex
* master
synced/master
|
After running @mguaypaq can you please merge it to master? Thanks in advance! |
it would be really nice to have a proper QC for centerline, ie: where we can see it from top to bottom without interruption. Tagging @joshuacwnewton so he is aware of this feature request (i think we already have an issue open about this) |
In that issue, @valosekj describes the exact same workaround that @naga-karthik has mentioned above. |
Done! |
Closing since the branch was merged into master. |
hi!
EDIT: The branch with the latest (corrected) centerlines is
ks/troubleshoot
. New branch was created due to a mix up. Future updates will only be this branch!The text was updated successfully, but these errors were encountered: