From c344b0da2d12128a7ba68379efc80275b80032bc Mon Sep 17 00:00:00 2001 From: James Kent Date: Thu, 26 Jan 2023 16:22:19 -0600 Subject: [PATCH 1/5] add note about SDM --- docs/cbma.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/cbma.rst b/docs/cbma.rst index e7cc1bf11..c191698e5 100644 --- a/docs/cbma.rst +++ b/docs/cbma.rst @@ -11,6 +11,9 @@ In other tools for CBMA, such as `GingerALE`_, most of the elements we discuss o However, we have chosen to modularize these elements in order to support a range of testing possibilities, such as combining different kernels with different estimators. +.. note:: + Seed Based *d* Mapping (SDM) is currently not implemented in NiMARE because the source code is not publicly available. + First, let's describe, in basic terms, what each of these elements means. Kernels From 2a1a1303641a27c029db7a9f70a4a21118cc3fdf Mon Sep 17 00:00:00 2001 From: James Kent Date: Thu, 26 Jan 2023 16:28:35 -0600 Subject: [PATCH 2/5] move to api docs --- docs/api.rst | 3 +++ docs/cbma.rst | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/api.rst b/docs/api.rst index 8920c1e60..2434b7600 100644 --- a/docs/api.rst +++ b/docs/api.rst @@ -26,6 +26,9 @@ API For more information about the components of coordinate-based meta-analysis in NiMARE, see :doc:`cbma`. +.. note:: + Seed Based *d* Mapping (SDM) is currently not implemented in NiMARE because the source code is not publicly available. + .. automodule:: nimare.meta :no-members: :no-inherited-members: diff --git a/docs/cbma.rst b/docs/cbma.rst index c191698e5..e7cc1bf11 100644 --- a/docs/cbma.rst +++ b/docs/cbma.rst @@ -11,9 +11,6 @@ In other tools for CBMA, such as `GingerALE`_, most of the elements we discuss o However, we have chosen to modularize these elements in order to support a range of testing possibilities, such as combining different kernels with different estimators. -.. note:: - Seed Based *d* Mapping (SDM) is currently not implemented in NiMARE because the source code is not publicly available. - First, let's describe, in basic terms, what each of these elements means. Kernels From 89d0f19ab6b702eebd61cc7bf07280c19687a5f6 Mon Sep 17 00:00:00 2001 From: James Kent Date: Tue, 14 Feb 2023 10:02:43 -0600 Subject: [PATCH 3/5] remove sdm note from here --- docs/api.rst | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/api.rst b/docs/api.rst index 2434b7600..715d0212d 100644 --- a/docs/api.rst +++ b/docs/api.rst @@ -26,8 +26,6 @@ API For more information about the components of coordinate-based meta-analysis in NiMARE, see :doc:`cbma`. -.. note:: - Seed Based *d* Mapping (SDM) is currently not implemented in NiMARE because the source code is not publicly available. .. automodule:: nimare.meta :no-members: From b185e2cac77cf12b80b252e1a41f77fb2dbdebce Mon Sep 17 00:00:00 2001 From: James Kent Date: Tue, 14 Feb 2023 10:02:56 -0600 Subject: [PATCH 4/5] add sdm notes here --- docs/cbma.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/cbma.rst b/docs/cbma.rst index e7cc1bf11..c69191c49 100644 --- a/docs/cbma.rst +++ b/docs/cbma.rst @@ -170,6 +170,12 @@ The Monte Carlo FWE correction approach implemented in NiMARE produces three new although there is a closed pull request with an implementation that worked at the time it was closed (see `#655 `_). + +.. admonition:: Where is SDM? + + Seed Based *d* Mapping (SDM) is currently not implemented in NiMARE because the source code is not publicly available. + To follow the current discussion on SDM in the context of NiMARE, see `#183 `. + References ---------- .. footbibliography:: From 42b98c3f5f06611a7fc57821a80a4ffb4ed984b9 Mon Sep 17 00:00:00 2001 From: James Kent Date: Tue, 14 Feb 2023 11:55:43 -0600 Subject: [PATCH 5/5] fix hyperlink --- docs/cbma.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/cbma.rst b/docs/cbma.rst index c69191c49..190fdf09d 100644 --- a/docs/cbma.rst +++ b/docs/cbma.rst @@ -174,7 +174,7 @@ The Monte Carlo FWE correction approach implemented in NiMARE produces three new .. admonition:: Where is SDM? Seed Based *d* Mapping (SDM) is currently not implemented in NiMARE because the source code is not publicly available. - To follow the current discussion on SDM in the context of NiMARE, see `#183 `. + To follow the current discussion on SDM in the context of NiMARE, see `#183 `_. References ----------