Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Royalties might be messed up when using external NFTs #310

Open
mrsmkl opened this issue May 25, 2022 · 0 comments
Open

Royalties might be messed up when using external NFTs #310

mrsmkl opened this issue May 25, 2022 · 0 comments

Comments

@mrsmkl
Copy link
Collaborator

mrsmkl commented May 25, 2022

Describe the bug

If the NFT id is the same as some DID, the royalties for the DID will be used...

One way to resolve would be to add the NFT contract address to the parameters in in "lock" and "escrow".

To Reproduce

Steps to reproduce the behavior:
1.
2.

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrsmkl