Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node provenance used transactions should be batched #250

Open
aaitor opened this issue Nov 8, 2023 · 0 comments
Open

Node provenance used transactions should be batched #250

aaitor opened this issue Nov 8, 2023 · 0 comments

Comments

@aaitor
Copy link
Member

aaitor commented Nov 8, 2023

Currently when there are several requests to download files through the Node, multiple used transactions are sent. This has 2 problems:

Transaction replacement errors

WARN Unable to register on-chain provenance: Error: Keeper error: 
                ----------------------------------------

                Sending transaction "used" on contract "DIDRegistry" at 0x56C010A3B179A4Ec1c03e975F72a104bC1dE3dc5 failed.

                Error: Error: replacement fee too low (transaction="0x02f901b38205397b843b9aca00843b9aca108303c52f9456c010a3b179a4ec1c03e975f72a104bc1de3dc580b90144bb794d92367e2d802b7441f9b38d7e059aab6ea28cd4da3a27a24e799cfa15b406958d3e9814057fef2398d8e0d1f084b3ab7c7560cb701b934661a3432bae125bd27bbe000000000000000000000000a78deb2fa79463945c247991075e2a0e98ba7a0968f3cfe920d94b4f8484d4dbcdd148349488d236022148d3a6a2526fa819257000000000000000000000000000000000000000000000000000000000000000c0000000000000000000000000000000000000000000000000000000000000010000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000f646f776e6c6f61642066696c6520310000000000000000000000000000000000c001a058660f9d08d60c56589d6f7d71a9afd8fbaa03741daed477822263e1a02739fba05d2dee9884f35c03db999fa19ad66c1121f4895a58d32d698cc719c6fd69f54e", info={ "error": { "code": -32000, "message": "replacement transaction underpriced" } }, code=REPLACEMENT_UNDERPRICED, version=6.7.1)

                From: 0x068Ed00cF0441e4829D9784fCBe7b9e26D4BD8d0

                Parameters: [
  {
    "name": "_provId",
    "value": "0x367e2d802b7441f9b38d7e059aab6ea28cd4da3a27a24e799cfa15b406958d3e"
  },
  {
    "name": "_did",
    "value": "0x9814057fef2398d8e0d1f084b3ab7c7560cb701b934661a3432bae125bd27bbe"
  },
  {
    "name": "_agentId",
    "value": "0xA78deb2Fa79463945C247991075E2a0e98Ba7A09"
  },
  {
    "name": "_activityId",
    "value": "0x68f3cfe920d94b4f8484d4dbcdd148349488d236022148d3a6a2526fa8192570"
  },
  {
    "name": "_signatureUsing",
    "value": "0x0000000000000000000000000000000000000000000000000000000000000000"
  },
  {
    "name": "_attributes",
    "value": "download file 1"
  }
]

Performance

Provenance transactions are sent one by one so it would be better to batch them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants