Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to set nextButtonText and backButtonText to components #108

Open
danielsetreus opened this issue Aug 23, 2018 · 3 comments · May be fixed by #165
Open

Ability to set nextButtonText and backButtonText to components #108

danielsetreus opened this issue Aug 23, 2018 · 3 comments · May be fixed by #165

Comments

@danielsetreus
Copy link

Hi

Would like to do something like:

<StepZilla
	steps={steps}
	nextTextOnFinalActionStep={"FooBar"}
	nextButtonText={<Fragment>Next <i className="icon--arrow-right"></i></Fragment>}
	backButtonText={<Fragment><i className="icon--arrow-left"></i> Back</Fragment>}
/>

Although this works, it gives a PropTypes warning (nextButtonText / backButtonText must be string) Could you make the validation so that it also accepts a react component?

@newbreedofgeek
Copy link
Owner

Good to know it works, let me do some tests and update the core to also support a React component.

@zeel
Copy link
Collaborator

zeel commented Nov 16, 2020

created pr for same.

@gtwilliams03
Copy link

Is there any update on this feature request? The PR is still open and I still get warnings setting backButtonText and nextButtonText to components instead of text. I also opened #72 on this issue also and @zeel mentioned that there might be a backButtonNode and nextButtonNode option? Thanks! I use this library in multiple projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants