fixed #153 #157
Open
fixed #153 #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@newbreedofgeek Can we merge this PR? |
| @@ -29,7 +29,7 @@ export default class StepZilla extends Component { | |||
| } else { | |||
| // check if isValidated was exposed in the step, if yes then set initial state as not validated (false) or vice versa | |||
| // if HOCValidation is used for the step then mark it as "requires to be validated. i.e. false" | |||
| i.validated = i.component.type && i.component.type.prototype && i.component.type.prototype.isValidated && this.isStepAtIndexHOCValidationBased(idx) ? false : true; | |||
| i.validated = i.component.type && i.component.type.prototype && i.component.type.prototype.isValidated && !this.isStepAtIndexHOCValidationBased(idx) ? false : true; | |||
There was a problem hiding this comment.
Unfortunately does not fix it @zeel-swiggy - when you make this change it stop your jumping to Step 4, but it wont stop you from jumping to step 5 (i.e. it skips validation check for HOCValidation Step)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #153