Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .NET Framework dependency on .NET Standard #2898

Closed
chynesNR opened this issue Nov 20, 2024 · 2 comments · Fixed by #2896
Closed

Remove .NET Framework dependency on .NET Standard #2898

chynesNR opened this issue Nov 20, 2024 · 2 comments · Fixed by #2896
Labels
bug Something isn't working

Comments

@chynesNR
Copy link
Member

When we updated SharpZipLib from version 1.3.3 to 1.4.2 in this PR, we didn't notice that they removed their .NET Framework target and now only have a .NET Standard target. While this works in most .NET Framework settings, it is possible to deploy without netstandard.dll, which results in a runtime failure for our agent.

I have gone through our other dependencies and don't see any other libraries we depend on that have dropped their .NET Framework target.
@chynesNR chynesNR added the bug Something isn't working label Nov 20, 2024
@workato-integration
Copy link

https://new-relic.atlassian.net/browse/NR-342172

@chynesNR chynesNR mentioned this issue Nov 21, 2024
Merged
@workato-integration
Copy link

Work has been completed on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove .NET Standard libraries from .NET Framework target newrelic/newrelic-dotnet-agent
1 participant
@chynesNR