Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New quickstart kong #2593

Merged
merged 2 commits into from
Oct 28, 2024
Merged

feat: New quickstart kong #2593

merged 2 commits into from
Oct 28, 2024

Conversation

jcountsNR
Copy link
Contributor

@jcountsNR jcountsNR commented Oct 24, 2024

Summary

Request from @louisleungk for a quickstart. uses Kong logs.

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?
  • Are you trying to create standalone alerts? Standalone alerts are deprecated. They should only be included in quickstarts.

Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcountsNR, I have noticed that this integration doesn't have a datasource. Is this quickstart intended for use without a datasource?

@jcountsNR
Copy link
Contributor Author

@sjyothi54 I added a datasource here. Since it is a logging integration, there isn't a custom dashboard alongside it, just the ootb logs viewer.

Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RamanaReddy8801 RamanaReddy8801 merged commit a368c57 into release Oct 28, 2024
12 checks passed
@RamanaReddy8801 RamanaReddy8801 deleted the jc-kong branch October 28, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants