Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Improve prune dump and integration test #201

Open
imyousuf opened this issue Jan 2, 2025 · 0 comments
Open

[FEATURE] Improve prune dump and integration test #201

imyousuf opened this issue Jan 2, 2025 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@imyousuf
Copy link
Collaborator

imyousuf commented Jan 2, 2025

Is your feature request related to a problem? Please describe.
The first iteration of prune writes the messages twice, once within the message and then within the job object. This will cause unnecessary space consumption. So we will want to control what is written to the JSONL files. Also the integration test does not verify what is being exported, we should have some assertion.

Describe the solution you'd like
Message payload should be exported exactly once.

Describe alternatives you've considered
None considered

Additional context
This issue is a branch of #154

@imyousuf imyousuf added enhancement New feature or request help wanted Extra attention is needed labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant