From 993193e83c722ffb21b26796443f6f8eb4dba643 Mon Sep 17 00:00:00 2001
From: Louis <louis@chmn.me>
Date: Wed, 2 Oct 2024 16:39:36 +0200
Subject: [PATCH] fix!: Require actionsAriaLabel in NcListItem

Signed-off-by: Louis Chemineau <louis@chmn.me>
---
 l10n/messages.pot                        |  3 ---
 src/components/NcListItem/NcListItem.vue | 11 +++--------
 2 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/l10n/messages.pot b/l10n/messages.pot
index 59eba91aa8..9b34402046 100644
--- a/l10n/messages.pot
+++ b/l10n/messages.pot
@@ -21,9 +21,6 @@ msgstr ""
 msgid "Actions"
 msgstr ""
 
-msgid "Actions for item with name \"{name}\""
-msgstr ""
-
 msgid "Activities"
 msgstr ""
 
diff --git a/src/components/NcListItem/NcListItem.vue b/src/components/NcListItem/NcListItem.vue
index 5d35e1751e..fce48efc15 100644
--- a/src/components/NcListItem/NcListItem.vue
+++ b/src/components/NcListItem/NcListItem.vue
@@ -512,7 +512,7 @@ The `actions-icon` slot can be used to pass icon to the inner NcActions componen
 					<NcActions ref="actions"
 						:primary="isActive || active"
 						:force-menu="forceMenu"
-						:aria-label="computedActionsAriaLabel"
+						:aria-label="actionsAriaLabel"
 						@update:open="handleActionsUpdateOpen">
 						<template v-if="$slots['actions-icon']" #icon>
 							<!-- @slot Provide the custom icon for the right side quick menu -->
@@ -536,7 +536,6 @@ The `actions-icon` slot can be used to pass icon to the inner NcActions componen
 import NcActions from '../NcActions/index.js'
 import NcCounterBubble from '../NcCounterBubble/index.js'
 import NcVNodes from '../NcVNodes/index.js'
-import { t } from '../../l10n.js'
 
 export default {
 	name: 'NcListItem',
@@ -563,7 +562,7 @@ export default {
 		 */
 		name: {
 			type: String,
-			required: true,
+			default: undefined,
 		},
 
 		/**
@@ -632,7 +631,7 @@ export default {
 		 */
 		actionsAriaLabel: {
 			type: String,
-			default: '',
+			required: true,
 		},
 
 		/**
@@ -715,10 +714,6 @@ export default {
 			return (this.details !== '' || this.hasDetails)
 				&& (!this.displayActionsOnHoverFocus || this.forceDisplayActions)
 		},
-
-		computedActionsAriaLabel() {
-			return this.actionsAriaLabel || t('Actions for item with name "{name}"', { name: this.name })
-		},
 	},
 
 	watch: {