Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NcAvatar): implement custom javascript hook action for the contacts menu #6238

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

st3iny
Copy link
Contributor

@st3iny st3iny commented Nov 19, 2024

☑️ Resolves

📒 Description

Adds a new contacts menu that is able to trigger hooks registered via registerContactsMenuAction("foo-bar").

export interface ContactsMenuAction {
	id: string,
	displayName: (entry: ContactsMenuEntry) => string,
	enabled: (entry: ContactsMenuEntry) => boolean,
	iconSvg: (entry: ContactsMenuEntry) => string,
	callback: (entry: ContactsMenuEntry) => void,
}

🖼️ Screenshots

Nothing really to show here. Please have a look here for an implementation.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@st3iny st3iny added enhancement New feature or request 2. developing Work in progress feature: avatar Related to the avatar component feature: functions composables, functions, mixins and other non-components labels Nov 19, 2024
@st3iny st3iny self-assigned this Nov 19, 2024
@st3iny st3iny marked this pull request as ready for review November 26, 2024 20:45
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 26, 2024
Copy link
Contributor

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/functions/contactsMenu/index.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: avatar Related to the avatar component feature: functions composables, functions, mixins and other non-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants