-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NcAvatar): implement custom javascript hook action for the contacts menu #6238
Open
st3iny
wants to merge
5
commits into
master
Choose a base branch
from
feat/NcAvatar/js-hook-action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts menu Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
added
enhancement
New feature or request
2. developing
Work in progress
feature: avatar
Related to the avatar component
feature: functions
composables, functions, mixins and other non-components
labels
Nov 19, 2024
This was referenced Nov 19, 2024
susnux
reviewed
Nov 20, 2024
susnux
reviewed
Nov 20, 2024
susnux
reviewed
Nov 20, 2024
susnux
reviewed
Nov 20, 2024
susnux
reviewed
Nov 20, 2024
susnux
reviewed
Nov 20, 2024
susnux
reviewed
Nov 20, 2024
susnux
reviewed
Nov 20, 2024
st3iny
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Nov 26, 2024
ChristophWurst
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
New feature or request
feature: avatar
Related to the avatar component
feature: functions
composables, functions, mixins and other non-components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
📒 Description
Adds a new contacts menu that is able to trigger hooks registered via
registerContactsMenuAction("foo-bar")
.🖼️ Screenshots
Nothing really to show here. Please have a look here for an implementation.
🏁 Checklist
next
requested with a Vue 3 upgrade