-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AppAPIService): encode query parameter arrays via http_build_query #412
Conversation
Signed-off-by: Edward Ly <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, better also to double check within the issue to confirm it works as expected now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge this and request backports.
I'll test it heavily this week with Flow and Visionatrix, after that we can approve & merge backports.
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/412/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2b307976
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/412/stable29 Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
…y [backport/stable29] (#424) Manual backport of #412 Signed-off-by: Alexander Piskun <[email protected]>
… [backport/stable30] (#422) Manual backport of #412 Signed-off-by: Alexander Piskun <[email protected]>
Resolves #384. If the checks still pass and this gets merged, perhaps we should take a look at other apps to see if they need to be updated in the same way.