Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: sync changes for Apps management migration to settings #417

Merged
merged 12 commits into from
Oct 29, 2024
Merged

chore: sync changes for Apps management migration to settings #417

merged 12 commits into from
Oct 29, 2024

Conversation

andrey18106
Copy link
Collaborator

@andrey18106 andrey18106 commented Oct 11, 2024 •
edited
Loading

This PR synchronizes backend logic for ExAppFetcher and required changes for Apps management.

Screen Shot 2024-10-14 at 17 01 48

TODO

@andrey18106 andrey18106 mentioned this pull request Oct 11, 2024
Merged
6 tasks
@andrey18106 andrey18106 changed the title chore: sync changes chore: sync changes for Apps management migration to settings Oct 11, 2024
bigcat88
bigcat88 approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works

julien-nc
julien-nc reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn't try it with the related server PR.
Do you want to include the changes dropping the UI stuff that is now in server? If so I'll wait for that to make another review.

@andrey18106
Copy link
Collaborator Author

Looks good. I didn't try it with the related server PR. Do you want to include the changes dropping the UI stuff that is now in server? If so I'll wait for that to make another review.

Removed unused UI parts now.

@julien-nc julien-nc self-requested a review October 14, 2024 14:05
@andrey18106
Copy link
Collaborator Author

/compile

@andrey18106
Copy link
Collaborator Author

/backport to stable30

@andrey18106 andrey18106 merged commit b8200b7 into main Oct 29, 2024
31 checks passed
@andrey18106 andrey18106 deleted the chore/fetcher/sync-changes branch October 29, 2024 19:26
@backportbot backportbot bot mentioned this pull request Oct 29, 2024
Merged
2 tasks
andrey18106 added a commit that referenced this pull request Oct 30, 2024
@backportbot @andrey18106 @nextcloud-command
[stable30] chore: sync changes for Apps management migration to setti…
ae9c911 
…ngs (#428)

Backport of #417

Warning, This backport's changes differ from the original and might be
incomplete ⚠️

## Todo 
- [x] Review and resolve any conflicts
- [ ] Amend HEAD commit to remove the line stating to skip CI
---

Learn more about backports at
https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

---------

Signed-off-by: Andrey Borysenko <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
Co-authored-by: Andrey Borysenko <[email protected]>
Co-authored-by: nextcloud-command <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

@julien-nc julien-nc julien-nc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrey18106 @julien-nc @bigcat88 @nextcloud-command