Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): do not expose haproxy password to UI #447

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

oleksandr-nc
Copy link
Contributor

@oleksandr-nc oleksandr-nc commented Nov 18, 2024

  1. Since we need a password of at least 12 characters, we use dummySecret123 instead of dummySecret
  2. checkDaemonConnection expects to get the full Deploy Daemon configuration from the UI, so we get the password from the database if we get dummySecret123 from the UI and the haproxy password is present in the database.
  3. I added comments everywhere in the code

Copy link
Collaborator

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@oleksandr-nc oleksandr-nc merged commit 940774b into main Nov 20, 2024
30 checks passed
@oleksandr-nc oleksandr-nc deleted the fix/hide-haproxypass-from-UI branch November 20, 2024 09:02
@oleksandr-nc
Copy link
Contributor Author

/backport to stable30

@oleksandr-nc
Copy link
Contributor Author

/backport to stable29

Copy link

backportbot bot commented Nov 21, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/447/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 6d2300ae 56eab3b3

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/447/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants